On Mon, May 27, 2013 at 12:40:25PM +0100, John Keeping wrote:
> Since commit f269048 (fetch: opportunistically update tracking refs,
> 2013-05-11) we update tracking refs opportunistically when fetching
> remote branches. However, if a refspec is given on the command line
> that does not include a configured (non-pattern) refspec a fatal error
> occurs.
I'm not sure I understand what the last sentence means. I tried to add a
test like:
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index ff43e08..02e30e1 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -422,6 +422,16 @@ test_expect_success 'configured fetch updates tracking' '
)
'
+test_expect_success 'non-configured ref does not confuse tracking update' '
+ cd "$D" &&
+ git update-ref refs/odd/location HEAD &&
+ (
+ cd three &&
+ git fetch origin refs/odd/location &&
+ git rev-parse --verify FETCH_HEAD
+ )
+'
+
test_expect_success 'pushing nonexistent branch by mistake should not segv' '
cd "$D" &&
but it does not fail with the existing code. Can you give an example
that fails?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html