On Mon, Jul 01, 2019 at 08:25:09AM -0400, Derrick Stolee wrote: > > I'm not sure what you have in mind, exactly. If you are asking whether > > there are more places that alternate refs could be used, I can't think > > of any. If you are asking whether this is in the wrong place, no, I > > think it's the right place. :) > > Just double-checking that it is appropriate for revision.c to take > dependence on transport.h instead of moving the alternate ref stuff > into a different header file. I trust your opinion.
Ah, I see. I misunderstood you before. Yes, this is weakening the ties of the feature to the transport code. Traditionally transport-oriented code was the only user, but it also used the upload-pack transport under the hood to access the alternate (that was changed a while ago to for-each-ref for speed). I don't think there's any functional difference in having it there, but it could be moved to live alongside foreach_alt_odb() in sha1-file.c. -Peff
