Jonathan Nieder <jrnie...@gmail.com> writes:
> Maybe something like:
>
> preload-index: use git_env_bool() not getenv() for customization
>
> GIT_FORCE_PRELOAD_TEST is only checked for presence by using getenv().
> Use git_env_bool() instead so that GIT_FORCE_PRELOAD_TEST=false can
> work as expected.
That is much better description. Also
$ cd t && GIT_FORCE_PRELOAD_TEST=t ./t0000-basic.sh
would have allowed us to enable the feature in the older world, but
I suspect it would instead fail the test, saying 't is not a bool
nor int'.
So strictly speaking, it is a backward incompatible change. I am
not sure if I like it.
>> Teach GIT_FORCE_PRELOAD_TEST to take a boolean to turn on or off this test
>> feature instead of simply testing for existance.
s/existance/existence/?
