On Wed, Aug 15, 2018 at 12:21 PM Duy Nguyen <[email protected]> wrote: > > On Wed, Aug 15, 2018 at 9:10 PM Stefan Beller <[email protected]> wrote: > > > > On Mon, Aug 13, 2018 at 9:15 AM Nguyễn Thái Ngọc Duy <[email protected]> > > wrote: > > > > > > Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]> > > > > This removes the only existing extern keyword, which was added by > > Linus in 933bf40a5c6 (Start moving unpack-trees to "struct tree_desc", > > 2007-08-09). All other callers do not have this noise word as it was > > simply never > > present there despite the old age of unpack-trees.h. Interesting history. > > Linus did not add 'extern' though. It was Johannes a year ago in > 16da134b1f (read-trees: refactor the unpack_trees() part - > 2006-07-30). Man this function is _old_.
Ah, yes. I stopped at the first blame here but dug down on other functions as I expected some of the recent "remove externs here" and magically overlook this function.
