On Sun, Jul 8, 2018 at 10:38 PM Jacob Keller <[email protected]> wrote: > On Sun, Jul 8, 2018 at 4:39 PM brian m. carlson > <[email protected]> wrote: > > static inline int oidcmp(const struct object_id *oid1, const struct > > object_id *oid2) > > { > > - return hashcmp(oid1->hash, oid2->hash); > > + return memcmp(oid1->hash, oid2->hash, the_hash_algo->rawsz); > > } > > Just curious, what's the reasoning for not using the hashcmp anymore?
hashcmp() is specific to SHA-1 (for instance, it hardocdes GIT_SHA1_RAWSZ). oidcmp() is meant as the hash-agnostic replacement for hashcmp(), so it doesn't make sense to continue implementing oidcmp() in terms of hashcmp() (the latter of which will eventually be retired, presumably).
