On Fri, Dec 15, 2017 at 11:35 AM, Michael J Gruber <g...@grubix.eu> wrote: > Ævar Arnfjörð Bjarmason venit, vidit, dixit 12.12.2017 23:26: >> >> On Tue, Dec 12 2017, Randall S. Becker jotted: >> >>> -----Original Message----- >>> On December 10, 2017 4:14 PM, Ævar Arnfjörð Bjarmason wrote: >>> Subject: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make >>> rules >>> >>>> Replace the perl/Makefile.PL and the fallback perl/Makefile used under >>>> NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily >>>> inspired by how the i18n infrastructure's build process works[1]. >>>> The reason for having the Makefile.PL in the first place is that it was >>>> initially[2] building a perl C binding to interface with libgit, this >>>> functionality, that was removed[3] before Git.pm ever made it to the >>>> master branch. >>> <big snip> >>> >>> I would like to request that the we be careful that the git builds do not >>> introduce arbitrary dependencies to CPAN. Some platforms (I can think of >>> one off the top, being NonStop) does not provide for arbitrary additions to >>> the supplied perl implementation as of yet. The assumption about being able >>> to add CPAN modules may apply on some platforms but is not a general >>> capability. I am humbly requesting that caution be used when adding >>> dependencies. Being non-$DAYJOB responsible for the git port for NonStop, >>> this scares me a bit, but I and my group can help validate the available >>> modules used for builds. >>> >>> Note: we do not yet have CPAN's SCM so can't and don't use perl for access >>> to git anyway - much that I've tried to change that. >>> >>> Please keep build dependencies to a minimum. >>> >>> Thanks for my and my whole team. >> >> I think you should be happy with this patch then, and it doesn't add any >> more CPAN dependency than before, and sets up a framework (as discussed >> in [1]) where we can use more CPAN modules while not requiring packagers >> such as yourself to package CPAN modules. >> >> However, it doesn't sound believable to me that even on NonStop you >> can't install any CPAN modules whatsoever. >> >> That would also mean that this patch doesn't work for you, because it >> means that you either don't have anything resembling a hierarchical >> filesystem on which git can be installed in the first place (in which >> case it wouldn't work), or perl doesn't have an @INC to search through >> perl libs on on NonStop. What does: >> >> perl -V >> >> Return for you on that system? >> >> If this patch works, and if at the bottom of `perl -V` you see some >> directories which you could write a package to drop some static *.pm >> files, then you can grab a *.tar.gz from CPAN such as the one for >> Error.pm[2] and arrange for the *.pm files contained within its lib/ >> directory to be dropped into one of those @INC directories. >> >> It may be that some aspect of the CPAN toolchain is broken for you, or >> even ExtUtils::MakeMaker, but you typically don't need that to package >> non-XS perl modules, certainly not any of the ones we've discussed >> possibly bundling up in git.git on-list recently. As a (very occasional) >> contributor to perl.git I'd be interested to know if that's what you >> mean is broken, and if so see if it could be fixed for you. >> >> 1. <CACBZZX58KpQ7=v8guffxumqq_ar6cmmoxypx_umutbu19+0...@mail.gmail.com> >> -- >> https://public-inbox.org/git/CACBZZX58KpQ7=v8guffxumqq_ar6cmmoxypx_umutbu19+0...@mail.gmail.com/ >> >> 2. https://cpan.metacpan.org/authors/id/S/SH/SHLOMIF/Error-0.17025.tar.gz >> > > This patch (currently in origin/next) makes a ton of tests from our test > suite fail for me on pretty standard systems (Fedora 27, CentOS 7.4.1708). > > Is there anything I'm supposed to do differently now to make our test > suite run? If yes then a clear and short hint in the patch description > would me more than approriate.
This is a bug in my patch, I can reproduce it on CO7. Will figure out what's going on there...
