On Mon, Oct 30, 2017 at 08:48:48AM -0400, Ben Peart wrote: > Any updates or thoughts on this one? While the patch has become quite > trivial, it does results in a savings of 5%-15% in index load time.
I like the general direction of avoiding the check during each read. But... > I thought the compromise of having this test only run when DEBUG is defined > should limit it to developer builds (hopefully everyone developing on git is > running DEBUG builds :)). Since the test is trying to detect buggy code > when writing the index, I thought that was the right time to test/catch any > issues. I certainly don't build with DEBUG. It traditionally hasn't done anything useful. But I'm also not convinced that this is a likely way to find bugs in the first place, so I'm OK missing out on it. But what we probably _do_ need is to make sure that "git fsck" would detect such an out-of-order index. So that developers and users alike can diagnose suspected problems. -Peff
