On Tue, Jun 27, 2017 at 1:11 AM, Prathamesh Chavan <pc44...@gmail.com> wrote: > + > + if (!is_submodule_populated_gently(list_item->name, NULL)) > + goto cleanup; > + > + prepare_submodule_repo_env(&cp.env_array); > + /* For the purpose of executing <command> in the submodule, > + * separate shell is used for the purpose of running the > + * child process. > + */
As this comment spans over more than one line, it should be like: /* * first line of comment * second line of comment * more stuff ... */ Also please explain WHY a shell is needed, we can see from the code that we will use a shell. So it should be something like: /* * Use a shell because ... * and ... */ > + cp.use_shell = 1; > + cp.dir = list_item->name;
