On Wed, Nov 9, 2016 at 1:57 AM, Duy Nguyen <[email protected]> wrote: > On Sat, Oct 29, 2016 at 1:54 AM, Stefan Beller <[email protected]> wrote: >> The pathspec mechanism is extended via the new >> ":(attr:eol=input)pattern/to/match" syntax to filter paths so that it >> requires paths to not just match the given pattern but also have the >> specified attrs attached for them to be chosen. >> >> Signed-off-by: Stefan Beller <[email protected]> >> Signed-off-by: Junio C Hamano <[email protected]> >> --- >> Documentation/glossary-content.txt | 20 +++++ >> dir.c | 35 ++++++++ > > Pathspec can be processed in a couple more places. The big two are > match_pathspec and tree_entry_interesting, the former traverses a list > while the latter does a tree. You don't have to implement attr > matching in tree_entry_interesting right now because nobody needs it, > probably. But you need to make sure if somebody accidentally calls > tree_entry_interesting with an attr pathspec, then it should > die("BUG"), not silently ignore attr. >
I am looking into this now.
