Adam Spiers <[email protected]> writes:
> 1. Change the color of individual known breakages from bold green to
> bold yellow. This seems more appropriate when considering the
> universal traffic lights coloring scheme, where green conveys the
> impression that everything's OK, and amber that something's not
> quite right.
>
> 2. Likewise, change the color of the summarized total number of known
> breakages from bold red to bold yellow to be less alarmist and more
> consistent with the above.
>
> 3. Change color of unexpectedly fixed known breakages to bold red. An
> unexpectedly passing test indicates that the test is wrong or the
> semantics of the code being tested have changed. Either way this
> is an error which is arguably as bad as a failing test, and as such
> is now counted in the totals too.
I agree with Peff's comments.
The point #3 above wants to be a separate patch; we may even want to
consider a follow-up change to add an option to make a "test that is
expected to fail did not fail" case a failure.
> test_known_broken_ok_ () {
> test_fixed=$(($test_fixed+1))
> - say_color "" "ok $test_count - $@ # TODO known breakage"
> + test_broken=$(($test_broken+1))
> + say_color error "ok $test_count - $@ # TODO known breakage vanished"
> }
Also I wonder if this is still a "TODO". "# TODO fixed known breakage",
meaning that it is something that must be looked at by whoever happened
to have fixed the known breakage by accident, might be a better wording.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
