On 09/06/2005 02:08 PM, Junio C Hamano wrote:
> Jeff Carr <[EMAIL PROTECTED]> writes:
>
>
>>... If I remember
>>correctly, there was some threads at the beginning of git about how
>>datestamps were not accurate so there was no point in setting them(?) Or
>>maybe I mis-understood.
>
>
> The point of those thread was that clocks on machines tend to be
> not so accurate and we should not take the timestamps *too*
> seriously. We do record the time as accurately as the clock is
> maintained on the machine the commit is made, provided if the
> user does not override it with the GIT_COMMIT_DATE environment
> variable with a bogus value.
>
> The way you use it to show changes made in a certain timeperiod
> is a good example that the information is useful. The argument
> against relying on timestamp too much in that thread you are
> remembering was that it should not be used to see which commit
> came before which other commit when there is no parent-child
> ancestry between them. It is still a useful hint, and we do use
> it as such, but as the recent merge-base fixes show it is just a
> hint and relying on it too much tends to screw things up.
OK, I understand better now. I was just setting the mtime via the last
time the file showed up in the git-whatchanged output. When I check out
a repository I do:
git-read-tree -m HEAD && git-checkout-cache -q -f -u -a
git-restore-mtime
This is probably also a really bad reimplementation of something. :)
All and all, really enjoying using git. It's better.
Jeff
#!/usr/bin/perl
# parses git-whatchanged output and then
# sets the mtime for all the files # copyleft GPL
use strict;
use HTTP::Date;
# my $string = time2str($time); # Format as GMT ASCII time
# my $now = str2time($string); # convert ASCII date to machine time
my $oldest = localtime();
my %allfiles;
my $time;
# make a hash of all the files
foreach my $file ( split "\n", `git-ls-files` ) {
chomp $file;
$allfiles{ $file } = 0;
}
# get the newest mtime for each one
foreach my $line ( `git-whatchanged` ) {
chomp $line;
my @parts = split " ", $line;
if( $parts[0] eq "Date:" ) {
shift @parts;
pop @parts;
$time = str2time( join " ", @parts );
next;
}
if( $line =~ /^:/ ) {
my $name = pop @parts;
if( $allfiles{ $name } lt $time ) {
# print "$name was $allfiles{ $name } now: $time\n";
$allfiles{ $name } = $time;
}
if( $time lt $oldest ) {
$oldest = $time;
}
}
}
# set the mtime for each one
foreach my $name ( sort keys %allfiles ) {
if ( $allfiles{$name} eq 0 ) {
# print "$name mtime $allfiles{$name}\n";
utime $oldest, $oldest, $name;
} else {
# print "$name mtime $allfiles{$name}\n";
utime $allfiles{$name}, $allfiles{$name}, $name;
}
}
