On Thu, Oct 8, 2020 at 4:28 PM Ben Gamari <[email protected]> wrote:
> Phyx <[email protected]> writes: > > > Right, > > > > I think seems to be a bug in the script that wasn't noticed before. > > > > On line 40 there are () missing around the condition. So it's checking > both > > URLs i think. > > > > The download to Haskell.org succeeds but the msys2 one fails since that > > package is gone. > > > > The whole thing after the || needs to be in (). > > > > This would need to be fixed in that branch but the tag won't move. > > > > Any ideas here Ben? > > > I'm not sure what you mean by "the tag won't move". Could you clarify? > > Regardless, I do see that some parens are needed here. I have opened > #18821 to track this. > > For what it's worth, the download script was revamped in GHC 8.10 so I > don't think there is anything needed on master or ghc-8.10. > > I confirm that the specific script 'mk/get-win32-tarballs.sh' is not present in 8.10. There is a get-win32-tarballs.py there. Looks like the last version with the .sh was 8.8.4 > Cheers, > > - Ben > -- Shayne Fletcher
_______________________________________________ ghc-devs mailing list [email protected] http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
