Devs I’m at a loss for how to review GitLab changes. Richard sent me the message below. So I follow the link to “View on GitLab”, or I manually edit the URL to plain https://gitlab.haskell.org/ghc/ghc/merge_requests/116
Either way, I can’t see any comments whatsoever! It says 5/5 discussions resolved, but I can’t actually see them. There is not “toggle discussion” button anywhere. What should I do? This is quite a big problem. I suppose we could issue guidance NEVER to resolve a discussion, but that seems like the wrong conclusion. Simon From: Richard Eisenberg <[email protected]> Sent: 14 January 2019 03:03 To: Simon Peyton Jones <[email protected]> Subject: Re: GHC | Some refactoring in tcInferApps (!116) Richard Eisenberg<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Frae&data=02%7C01%7Csimonpj%40microsoft.com%7Cdb561c2c415642e1b95808d679cccdca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830317886025072&sdata=Tx8acLx5EqMZwPI5HaGByevMrszvpZMS0pk2S1YvHGg%3D&reserved=0> commented on a discussion on compiler/typecheck/TcHsType.hs<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%23note_2524&data=02%7C01%7Csimonpj%40microsoft.com%7Cdb561c2c415642e1b95808d679cccdca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830317886025072&sdata=axuADDuUAzYZkIDkS1Rnlt9Up13CbVG%2FKUgQYf4C38g%3D&reserved=0>: 1022 + (vcat [ ppr ki_binder 1023 + , ppr ki_arg 1024 + , ppr (tyBinderType ki_binder) 1025 + , ppr subst 1026 + , ppr (isInvisibleBinder ki_binder) ]) 1027 + ; ty_app_err ki_arg $ nakedSubstTy subst $ 1028 + mkPiTys all_ki_binders inner_ki } 1029 + 1030 + -- no binder; try applying the substitution, or fail if that's not possible 1031 + | otherwise 1032 + = try_again_after_substing_or n subst fun inner_ki all_args $ \ substed_inner_ki -> 1033 + ty_app_err ki_arg substed_inner_ki 1034 + 1035 + go n subst fun all_ki_binders inner_ki all_args@(HsValArg arg : args) 1036 + | ki_binder : ki_binders <- all_ki_binders 1037 + = if isInvisibleBinder ki_binder See if you like how I've done this now. — View it on GitLab<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%23note_2524&data=02%7C01%7Csimonpj%40microsoft.com%7Cdb561c2c415642e1b95808d679cccdca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830317886035081&sdata=M4jE8Z%2F0znjU9m7U2xMoPdytqCw6w4WAoVtAjjmC4%2BM%3D&reserved=0>. You're receiving this email because of your account on gitlab.haskell.org. If you'd like to receive fewer emails, you can unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fsent_notifications%2F5489179cb3c2c8e4eb34f7a8abd8016e%2Funsubscribe&data=02%7C01%7Csimonpj%40microsoft.com%7Cdb561c2c415642e1b95808d679cccdca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830317886045089&sdata=dvqIZ%2BabXOGv8nX2uMse3dl1XlyEvsxyVKIxPLRvG%2BE%3D&reserved=0> from this thread or adjust your notification settings.
_______________________________________________ ghc-devs mailing list [email protected] http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
