> On 3 Jan 2022, at 18:23, Mike Gilbert <flop...@gentoo.org> wrote: > On Mon, Jan 3, 2022 at 12:49 PM Adrian Ratiu <adrian.ra...@collabora.com > <mailto:adrian.ra...@collabora.com>> wrote: >> >> Starting with kernel>=v5.7 the build system can override the >> tools vars by setting LLVM=1 [1], but older kernels still use >> the default GNU tools, so to be able to use a full LLVM/Clang >> build, CC & co should be set to their respective portage values. >> >> [1] a0d1c951ef08 kbuild: support LLVM=1 to switch the default tools to >> Clang/LLVM >> >> Co-authored-by: Manoj Gupta <manojgu...@chromium.org> >> Signed-off-by: Adrian Ratiu <adrian.ra...@collabora.com> >> [snip] > > This seems ok to me, at least given the way the eclass currently works. > > At some point, we should really convert xmakeopts into an array. Any > of these variables might contain spaces, and that would break the > current implementation.
agreed, but lgtm
signature.asc
Description: Message signed with OpenPGP
