On Sun, Aug 15, 2021 at 6:55 AM Ulrich Müller <u...@gentoo.org> wrote:
>
> Eclass documentation and the elog message indicate that the expected
> location to install the file is /usr/share/doc/${PF}/README.gentoo,
> not the location of the ebuild's last docinto call.
>
> Signed-off-by: Ulrich Müller <u...@gentoo.org>
> ---
> eclass/readme.gentoo-r1.eclass | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/readme.gentoo-r1.eclass b/eclass/readme.gentoo-r1.eclass
> index 69d0e1c5c6b4..bebdba5b705a 100644
> --- a/eclass/readme.gentoo-r1.eclass
> +++ b/eclass/readme.gentoo-r1.eclass
> @@ -76,7 +76,10 @@ readme.gentoo_create_doc() {
> die "You are not specifying README.gentoo contents!"
> fi
>
> - dodoc "${T}"/README.gentoo
> + ( # subshell to avoid pollution of calling environment
> + docinto .
> + dodoc "${T}"/README.gentoo
> + )
I believe the current handling "die" in subshells terminates execution
at the end of the current phase.
Maybe add "|| die" after the subshell so that execution stops
immediately if dodoc fails.
