>>>>> On Thu, 17 Jun 2021, David Michael wrote: > @@ -33,15 +34,12 @@ _FCAPS_ECLASS=1 > > IUSE="+filecaps" > > -# Since it is needed in pkg_postinst() it must be in RDEPEND > +# Since it is needed in pkg_postinst() it must be in IDEPEND > case "${EAPI:-0}" in > - [0-6]) > - RDEPEND="filecaps? ( sys-libs/libcap )" > - ;; > - *) > - BDEPEND="filecaps? ( sys-libs/libcap )" > - RDEPEND="${BDEPEND}" > - ;; > + 7) BDEPEND="filecaps? ( sys-libs/libcap )" ;&
This is ill-defined in old EAPIs (5 and before), so the case statement may fail. You cannot use ;& in global scope of an eclass. Why not just change * to 7, and add a new case for 8? It's one additional line, and IMHO would be better readable than having a fallthrough. > + 6) RDEPEND="filecaps? ( sys-libs/libcap )" ;; > + 8) IDEPEND="filecaps? ( sys-libs/libcap )" ;; > + *) die "EAPI ${EAPI:-0} is unsupported" ;; > esac > > # @ECLASS-VARIABLE: FILECAPS Ulrich
signature.asc
Description: PGP signature