> On 9 Apr 2021, at 22:10, Joerg Bornkessel <hd_bru...@gentoo.org> wrote: > > https://bugs.gentoo.org/show_bug.cgi?id=778815 > > pkgcheck, gives an error like this > VariableScope: vdr-plugin-2: variable 'WORKDIR' used in > 'vdr-plugin-2_pkg_setup', line 371 >
Hi, thanks for looking into this!
> inserted patch will fix this issues
Could you make the change in a git checkout and then use ‘git format-patch’ and
then
git send-email to send it here?
>
> <snip>
> --- vdr-plugin-2.eclass 2020-02-23 17:39:40.000000000 +0100
> +++ vdr-plugin-2_QA-fixed.eclass 2021-04-06 23:27:37.358477036 +0200
> @@ -368,7 +368,7 @@
> VDR_INCLUDE_DIR="/usr/include/vdr"
> DVB_INCLUDE_DIR="/usr/include"
>
> - TMP_LOCALE_DIR="${WORKDIR}/tmp-locale"
> + TMP_LOCALE_DIR="${T}/tmp-locale"
>
> LOCDIR=$(pkg-config --variable=locdir vdr)
> </snap>
>
This looks fine as-is, although you may want to take the opportunity
to do some other clean ups, like replacing pkg-config with
$(tc-getPKG_CONFIG) to respect the ${PKG_CONFIG} variable
for e.g. cross-compilation.
We should add pkg-config to BDEPEND in EAPI 7 if it’s needed too.
It looks like there are some missing || dies on e.g. sed and other
external commands too which we could fix.
> i did several tests on my setup, it works like expected.
> please review, thanks...
>
> --
> Joerg Bornkessel <hd_bru...@gentoo.org>
> GnuPG Key: 0x93EB5F4DAA5832A1
> Fingerprint: 0E0A A1EE 1DF4 41D7 A3F5 21C2 93EB 5F4D AA58 32A1
>
signature.asc
Description: Message signed with OpenPGP
