On Fri, 2021-01-08 at 22:05 +0100, Thomas Deutschmann wrote: > On 2021-01-08 21:58, Michał Górny wrote: > > > +# @ECLASS-VARIABLE: ACCT_USER_ALREADY_EXISTS > > > +# @INTERNAL > > > +# @DESCRIPTION: > > > +# Status variable which indicates if user already exists. > > > > Please prefix internal variables with an underscore. > > You mean renaming ACCT_USER_ALREADY_EXISTS to _ACCT_USER_ALREADY_EXISTS?
Yes. > > Then _ACCT_USER_ALREADY_EXISTS would deviate from ACCT_USER_NAME which > has no underscore prefix and is also marked as internal variable. > > Or should I fix both? ACCT_USER_NAME is a 'visible' variable. I probably shouldn't have marked it internal. -- Best regards, Michał Górny
