On 2020-08-29 21:53, Michał Górny wrote:

> +     newins - ${CATEGORY}-${ACCT_USER_NAME}.conf < <(
> +             printf "u\t%q\t%q\t%q\t%q\t%q\n" \
> +                     "${ACCT_USER_NAME}" \
> +                     "${ACCT_USER_ID/#-*/-}:${ACCT_USER_GROUPS[0]}" \
> +                     "${DESCRIPTION//[:,=]/;}" \

Maybe it's a fault in how I have tested this (i.e. in an interactive
bash session, by setting all the variables and copy-pasting the relevant
printf lines by hand) but for me this results in an unquoted GECOS
string with spaces escaped with backslashes, whereas sysusers.d(5)
explicitly states this should be enclosed in quotation marks. Could you
double-check, please?

Otherwise LGTM.

-- 
MS

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to