(WilliamH: apologies for duplicate, I replied directly to you instead of the list the first time around)
On Wed, Feb 19, 2020 at 12:10:46AM -0600, William Hubbs wrote: > > +EGO_PN=github.com/aquasecurity/kube-bench > You shouldn't need EGO_PN Copied from th previous -r0. > > > +DESCRIPTION="Kubernetes Bench for Security runs the CIS Kubernetes > > Benchmark" > > +HOMEPAGE="https://github.com/aquasecurity/kube-bench"; > > + > > +EGO_SUM=( > > + "cloud.google.com/go v0.26.0/go.mod > > h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" > > + "cloud.google.com/go v0.34.0/go.mod > > h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" > > + "cloud.google.com/go v0.37.4 > > h1:glPeL3BQJsbF6aIIYfZizMwc5LTYz250bDMjttbBGAU=" > > + "cloud.google.com/go v0.37.4/go.mod > > h1:NHPJ89PdicEuT9hdPXMROBD91xc5uRDxsMtSB16k7hw=" ... > > +) > > There's a lot of duplication in here. For example, the only difference > between the last two lines is one has /go.mod tacked onto the end of the > version. Do we need both lines for each module? If we intend on validating h1: then yes, because we need to do it for the .zip and .mod. > > +src_unpack() { > > + unpack ${P}.tar.gz > > + go-module_src_unpack > > +} > Can we do this some how in go-module_src_unpack so we don't have to > boiler-plate it to every consumer? See discussion in eclass thread. -- Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Treasurer E-Mail : [email protected] GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136
signature.asc
Description: PGP signature
