>>>>> On Tue, 31 Dec 2019, David Seifert wrote:
> On Tue, 2019-12-31 at 05:34 +0100, Michał Górny wrote:
>> --- a/eclass/ruby-ng.eclass
>> +++ b/eclass/ruby-ng.eclass
>> @@ -137,7 +137,7 @@ ruby_samelib() {
>> local res=
>> for _ruby_implementation in $(_ruby_get_all_impls); do
>> has -${_ruby_implementation} $@ || \
>> - res="${res}ruby_targets_${_ruby_implementation}
>> ?,"
>> + res="${res}ruby_targets_${_ruby_implementation}
>> ?(-),"> https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-830008.3.4 > In a 4-style use dependency, the flag name may *immediately* be > followed by a default specified by either (+) or (-) > https://github.com/gentoo-mirror/gentoo/blob/stable/metadata/md5-cache/dev-libs/boost-1.72.0 > >=dev-python/numpy-1.17[python_targets_python3_6(-)?,...] > Given that you ran this through CI, this smells of dead code... AFAICS, ruby_samelib() was called only by _ruby_atoms_samelib(), and that function has been removed in 2010 [1]. No direct calls (ever) from any ebuild in the Gentoo repo. So yes, ruby_samelib() seems to be dead code. Ulrich [1] https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/ruby-ng.eclass?r1=1.16&r2=1.17
signature.asc
Description: PGP signature
