On Tue, Dec 10, 2019 at 9:50 AM Michael Orlitzky <m...@gentoo.org> wrote: > > For esoteric packages with a dedicated user, though, you're probably > right. The main benefit of the mailing list posts so far is that they > let me track down pull requests and suggest that people ignore the > example in the devmanual. >
Do the list reviews really put people off that much? It seems like eclasses. Plenty of packages have one-off eclasses that nobody cares about except the specific project, in which case the list posts are just a formality and largely a NOOP. However, this list isn't really high-traffic. Ditto with last-rites and so on. I think having the opportunity for review is probably worth it even if often it is just a NOOP. If people are afraid to post something for review because of potential criticism then maybe we need to work more to make sure people understand that everybody makes mistakes and nobody knows everything, and this is why we have reviews in the first place. Nobody is going to have their commit access removed because they didn't notice something and were thoughtful enough to get more eyes on it before commiting it. IMO that is a sign of responsible commit access. -- Rich
