On Thu, 5 Sep 2019 09:04:23 -0500 Gordon Pettey <petteyg...@gmail.com> wrote:
> You'll note the bit you quoted in defense of skipping review says > "changes", and the bit about new eclasses says "do not skip this step". Emphasis added: ----- BEFORE committing a NEW eclass to the tree, it SHOULD be emailed to the gentoo-dev mailing list with a justification and a proposed implementation. DO NOT SKIP this step — sometimes a better implementation or an alternative which does not require a new eclass will be suggested. ----- If its mandatory, it must say "MUST" not "SHOULD", SHOULD is a suggestion, following a suggestion with an imperative just adds predictable confusion. Either fix the "should", or drop the "DO NOT SKIP". Otherwise you're just giving mixed messages.
pgp3DvpDDsd3I.pgp
Description: OpenPGP digital signature
