On Sun, Jul 29, 2018 at 4:17 AM, Andrew Savchenko <birc...@gentoo.org> wrote: > On Sun, 29 Jul 2018 16:47:47 +0900 Alice Ferrazzi wrote: >> Sent from my phone. Please excuse my brevity. >> >> On Sun, 29 Jul 2018, 16:39 Fabian Groffen, <grob...@gentoo.org> wrote: >> >> > Completely agreeing with Sergei, with some additional suggestions: >> > >> > On 28-07-2018 23:14:12 +0100, Sergei Trofimovich wrote: >> > > On Sun, 29 Jul 2018 00:40:18 +0300 >> > > Mikle Kolyada <zlog...@gentoo.org> wrote: >> > > >> > > > Hello, >> > > > >> > > > The Gentoo QA team would like to introduce the following policy that >> > > > would be applied to individuals breaking the state and quality of the >> > > > main gentoo.git tree >> > > > >> > > > ( as we do not have this strictly documented yet): >> > > > >> > > > <policy> >> > > > >> > > > If recommended >> > > >> > > It's not called "recommended" but "enforced". >> > >> > I agree. If you put penalties on these, they become hard rules. I >> > think that change should be discussed by the council perhaps? > > +1. Also please provide some tool for developers to check for > compliance to these rules, e.g. repoman full must perform all these > checks. > > If developers have no way to verify correctness of the code, they > can't be held responsible for accidental violation of the rules. > >> > > > the standard QA >> > > > procedure is: >> > > > >> > > > 1.) Two warnings granted by QA team, after two independent breakages >> > > > 2.) Revoking the commit access for 14 days >> > > > >> > > > These violations will be evaluated individually by all QA team members. >> > > > Warnings can be revoked, if during 6 months period a developer makes at >> > > > least 20 non trivial changes not producing more breakages. > > Why 6 months period? Why time frame at all? 20 good commits sounds > OK. If you want time frame, then you should set autoexpire of > warning as well. > Best regards, > Andrew Savchenko
That reads to me as "warnings become permanent after six months if not remediated with 20 non-trivial good commits", not that they expire.
