On 07/10/2018 09:44 AM, Rich Freeman wrote:
> On Tue, Jul 10, 2018 at 9:38 AM kuzetsa <kuze...@gmail.com> wrote:
>>
>> I think authorship is a good point / distinction, Mart.
>>
>> Authorship was never shown in dev-timeline for addresses
>> which aren't @gentoo.org anyway. That's a separate issue,
>> so this policy change shouldn't affect proxy-maint?
>>
>
> Might I suggest bringing authorship issues into a separate thread? It
> really seems like a completely separate issue. IMO devs who are
> authors but not committers should probably also use their @g.o
> addresses, though it is a little less critical there. We're talking
> about the committer here, and the committer will always be a Gentoo
> dev for these repos, and I don't see any reason that we shouldn't have
> a matching email address between that and LDAP. The alternative would
> be to have some other key, and that just seems overly complex.
>
Authorship was brought up by: [ Mart Raudsepp <l...@gentoo.org> ]
It's germane, and wanting clarity doesn't hurt:
... as quoted here:
On 07/09/2018 06:29 AM, Mart Raudsepp wrote:
> As long as that doesn't imply authorship, which seems to be as planned
> (for committer field only, as you said). Hopefully it's easy for people
> to set it up so that it uses gentoo address for committer and something
> else for author, albeit I don't see any config for it, but should be
> able to at least go via a script that uses the appropriate env vars.
~{prune}~
> Mart
>
^ As I think Mart may have been asking:
(or maybe just a related concern)
To avoid mistakes and confusion, it should be stated
unambiguously if //only// the commit field should be
modified (if not already a @gentoo.org address), and
the author field (in particular, commits authored by
persons not in LDAP / without @gentoo.org addresses)
ought to be left as-is, or if the intent is to imply
that both fields need to be @gentoo.org address.
Stating clearly that the author field should be left
as-is (if it's set to a n...@gentoo.org address) is
probably enough here.
I think the confusion may have partly been the
subject line for this thread, vaguely worded:
["... use their @gentoo.org address ..."],
which may accidentally imply that committers need to
apply @gentoo.org in all fields, not just committer.
the word "only" was in a few places, but if skimming
the thread it may not have been obvious. ::shrug::
Also, I agree:
dev-timeline tool not recognizing authorship ought to
be an issue for a separate thread, as this one seems
to be about the metadata in the commits themselves.
--kuza
