On Wed, Apr 25, 2018 at 08:47:16AM +0200, Ulrich Mueller wrote: > >>>>> On Wed, 25 Apr 2018, Marty E Plummer wrote: > > >> I don't see much code duplication there, so I think it would be > >> cleaner to have a second eclass, rather than adding conditionals to > >> the existing one. > > > I mean if you take into account app-dicts/dictd-* and freedict.eclass; > > without the above pr (which I did originally have with a new eclass, > > until I realized that app-text/dictd's conf file hardcodes /usr/lib/dict > > anyways so the freedict dictionaries get [at least on amd64 and other > > targets which use/will use lib64] installed outside of the search path > > anyways) they are all almost entirely identical with the contents of > > freedict.eclass. > > > Another thought I had was moving the src_install into dict.eclass and > > have freedict inherit it, adding the differences. > > $ egrep -v '^(#|$)' freedict.eclass | wc -l > 18 > > IMHO not worth the effort for 18 lines of code. Keep it simple. > > Ulrich
Still, optimization or no, if app-text/dictd is looking at /usr/lib/dict unconditionally and the app-dict/freedict-* dict files are ending up in /usr/lib64/dict conditionally, something needs to be fixed about that.
