On Sun, Dec 4, 2016 at 6:18 PM, Andreas K. Huettel <dilfri...@gentoo.org> wrote: > > Please review. Given that I'm only tangentially involved with Apache myself, I > would like to keep the changes to the eclass minimal... > > [The last nontrivial changes to the eclass were made in 2012 and 2008.]
For future patches, please use git send-email if possible. Makes it easier to review in an email client. > + declare -f -F get_libdir > /dev/null || Nit: the -F option implies -f; passing both is unnecessary. Otherwise, the changes seem fine.