On Sun, Oct 2, 2016 at 1:28 PM, konsolebox <konsole...@gmail.com> wrote:
> On Sun, Oct 2, 2016 at 12:34 AM, Dan Douglas <orm...@gmail.com> wrote:
>> I'd be perfectly happy requiring bundled readline when USE="readline"
>> for bash versions incompatible with the installed readline,
>
> I guess that's another good way to solve the readline issue (when it
> comes to bash). But I'd prefer that it's not done automatically.
> Instead we should add a formal use flag like 'installed-readline'. We
> can add it to release versions of bash ([[ ${PV} != *_rc* ]] &&
> IUSE+=' +installed-readline'), and enable it by default. Then we
> change all `[[ ${PV} != *_rc* ]]` condition checks to `[[ ${PV} !=
> *_rc* ]] && use installed-readline`. `${PV} != *_rc*` probably should
> also be `${PV} != *_alpha* && ${PV} != *_beta* && ${PV} != *_rc*`.
> (See attached file for POC.)I missed disabling the dependency to readline when 'installed-readline' is disabled. Here's another example. I also fixed a repoman warning related to tinfo and renamed 'installed_readline' to 'installed-readline'. It installs and runs well with `USE='-installed-readline tinfo' emerge -v 'bash::local'`. The modifications related to tinfo by the way is related to this: https://bugs.gentoo.org/show_bug.cgi?id=588486. I can't install bash properly without it. -- konsolebox
bash-4.4.ebuild
Description: Binary data
