On Mon, 27 Jun 2016 17:04:41 -0500
Austin English <[email protected]> wrote:

> From ec0be3d1a808ea0c5bdd081a4bb935f86bf78d44 Mon Sep 17 00:00:00 2001
> From: Austin English <[email protected]>
> Date: Mon, 27 Jun 2016 16:58:07 -0500
> Subject: [PATCH 2/2] eclass/toolchain-funcs: add clang version functions

Why do you even ask for review if you can't wait till the weekend
before committing?

I've already told you twice that I'm opposed to adding version querying
functions for clang, especially for the use case you proposed. You
should check for features, and not keep a huge list of supported gcc,
clang, pathcc, icc... versions. With every random compiler pretending
to be a random version of every other compiler.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

Attachment: pgpRIqOjWqWeQ.pgp
Description: OpenPGP digital signature

Reply via email to