On Sat, 21 May 2016 00:06:01 +0100
Amadeusz Żołnowski <aide...@gentoo.org> wrote:

> >> +rebar_src_install() {
> >> +  debug-print-function ${FUNCNAME} "${@}"
> >> +
> >> +  local bin
> >> +  local dest="$(get_erl_libs)/${P}"
> >> +
> >> +  insinto "${dest}"
> >> +  doins -r ebin
> >> +  [[ -d include ]] && doins -r include
> >> +  [[ -d bin ]] && for bin in bin/*; do dobin "$bin"; done  
> >
> > Please don't do inlines like this.  
> 
> Is there a particular problem with this?

Readability and maintainability. At some point someone may want to
extend this, and it will no longer work as one-liner.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

Attachment: pgpKZpzxcpPIz.pgp
Description: OpenPGP digital signature

Reply via email to