On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" <j...@gentoo.org> wrote:
> commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > Author: Justin Lecher <jlec <AT> gentoo <DOT> org> > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 > Commit: Justin Lecher <jlec <AT> gentoo <DOT> org> > CommitDate: Fri Oct 30 12:03:49 2015 +0000 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df8e399c > > eclass: Use consistent place for then in if clause Excuse me but who are you exactly to take a random eclass and commit random style changes inside without even bothering to contact the author? Not to mention this commit message is incorrect as it doesn't state which eclass was modified. > > Signed-off-by: Justin Lecher <jlec <AT> gentoo.org> > > eclass/distutils-r1.eclass | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > index 185dd4f..dbd27a7 100644 > --- a/eclass/distutils-r1.eclass > +++ b/eclass/distutils-r1.eclass > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() { > > _distutils-r1_disable_ez_setup > > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]] > - then > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]]; > then This was intentionally wrapped to stay within 72-column line width. Not saying the eclass is perfect in keeping text width, especially with others committing random changes to it, but that's no reason to introduce further offenders. > # create source copies for each implementation > python_copy_sources > fi > -- Best regards, Michał Górny <http://dev.gentoo.org/~mgorny/>
pgp5lXhlCDDuw.pgp
Description: OpenPGP digital signature
