On Sat, 17 Oct 2015 12:07:03 -0400 "Anthony G. Basile" <bluen...@gentoo.org> wrote:
> On 10/17/15 11:00 AM, hasufell wrote: > > On 10/17/2015 03:47 PM, Alexis Ballier wrote: > >> On Sat, 17 Oct 2015 14:49:36 +0200 > >> hasufell <hasuf...@gentoo.org> wrote: > >> > >> [...] > >>> You can apply the patches post_unpack or post_src_prepare witht > >>> hooks. What's the problem? > >> autoreconf > >> > > Can you elaborate why this would be a problem? > > > hooks can only be run before/after phases. you can't control when > during a phase you might run eapply_user(). > > i see advantages to both eapply_user and using hooks. as the ebuild > writer, i may like to suggest patching at a certain point in the > ebuild and then could just absorb those patches as contributions, eg > i may want all patching done after some preliminary work in > src_prepare() but before eautoreconf. for other entry points, the > user can use hooks. > exactly :) (I should do 'one word comments' more often to have people explain it better than I'd do :p) or more in the line in what i was thinking: pre-phase hook might break ebuild patches; post-phase don't get autoreconf and are thus either ignored if maintainer mode is disabled or, if it is enabled, trigger qa warnings
