On Monday, September 21, 2015 12:00:28 AM James Le Cuirot wrote: > On Sun, 20 Sep 2015 18:54:24 -0400 > Fernando Rodriguez <frodriguez.develo...@outlook.com> wrote: > > > On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote: > > > On Sun, 20 Sep 2015 17:53:25 -0400 > > > Fernando Rodriguez <frodriguez.develo...@outlook.com> wrote: > > > > > > > On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote: > > > > > Dnia 2015-09-18, o godz. 20:09:16 > > > > > Fernando Rodriguez <frodriguez.develo...@outlook.com> > > > > > napisał(a): > > > > > > > > > > > Github allows editting of comments in pull requests. Is there > > > > > > a policy regarding that? I've noticed a comment disappear > > > > > > which makes the rest of the > > > > > > conversation seem out of place. > > > > > > > > > > We can't really do anything about that. However, we might soon > > > > > be mirroring all comments on Bugzilla where removing comments > > > > > is not permitted. > > > > > > > > I realize you can't control how users use that feature but there > > > > should be some policy about how developers use it. I opened at PR > > > > because I was asked in bugzilla. I received some suggestions to > > > > which I replied that most of them are not related to my PR but > > > > will still do them. After I pushed the changes the comment making > > > > the suggestions gets deleted. > > > > > > They are probably not deleted but merely hidden. There should be a > > > "Show outdated diff" link that will reveal them. > > > > Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking > > about deleted comments on Github. I can't find anyway to show them. > > No, I do mean GitHub. I believe deleted comments really do get deleted > but the ones that seemingly disappear when you amend a commit just get > hidden. See this pull request as an example. > > https://github.com/chef-cookbooks/enterprise-chef-common/pull/25 > > Notice the grey "Show outdated diff" links on right right.
I was refering to actual comments, but that's another annoyance. I think that link is only shown when somebody references the commit. Mine just disappear when I amend a commit. Maybe the QA bot could reference every commit. -- Fernando Rodriguez
