-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 08/13/2015 12:43 PM, Robin H. Johnson wrote: > On Thu, Aug 13, 2015 at 10:36:16AM -0500, William Hubbs wrote: >> I understood the usefulness of this line to some when we were >> using CVS since it expanded into the ebuild revision, date, etc. >> >> This expansion doesn't take place under git, so now I don't >> understand the usefulness of this line. If I have missed >> something, can someone fill me in, or if it isn't useful any more >> can we consider removing it? > The following is the official answer of Infra, regarding the $Id$ > expansion. > > The intent is that the ONLY place the keywords are expanded, will > be in the rsync export. FUTURE tense, it's not ready yet. > > If there is demand (and I think the consensus is actually the > OPPOSITE), we could also have it expand on your local checkouts. > > It expands to the hash of the blob of that file; and from that, you > can identify which commits the blob exists in. > > The primary use case of it is to allow users to easily see what > version of a given ebuild they are using. >
I honestly don't see the point of this when `git log` or even `git diff` or standard `diff` will tell you if what's in your overlay differs from the source. With some bash magic it could even be automated. The point of that 'feature' is to see what, if anything, has changed between one's overlay and Gentoo's running tree. A diff would not only be able to tell you *if* anything changed, but also *what*, without adding around 5-7 extra bytes per ebuild. Sure, it's only bytes, but when multiplied against the number of ebuilds we have, it can make a few hundred KB difference. When expanded, that number multiplies. Is it worth adding this extra bloat to something that a standard utility can expose better than a hash? Just my two cents. - -- Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVzbCnAAoJEAEkDpRQOeFwlvkP/1KVnAH09LmHlO7kFPdFhEvE IhoscaZc/Pve4QcLMwnWAq2T3Uq4EzqYW2hICyuOAvp6bvca1ybpv7U6k+FYws8V lSarmFidfd0LKRqwPzrEjZb6kVxkKefzsAyqAZK9JcU5AhkI6cjIjMRihbxSVAJv BphWmbZBVuU4ZmoRiUcGR0Qzhcd4D4K0qjk6R4r5yCKaU5ACXj+ul5FOiD4GmsKc 288YgkLO8l+MQhLAQ5Ie6lL5E3tfVzgJ2U0F6R7xIG0uT8kXU5p7OuBN3ATEP96E P92T6QIOGug4fjjpdInjQPMaY+NnF3x6LshHgRQXHO1lWNIceJKTX+em4VqU4JEH UCsWgh+QPppPXrXTNE0J94BMK0DLP2iiHxYFtKT8u7ABfhAOvuTbA6B/H2ujjIaT 919htZGbSt3JkLCo5/gxqrJbntmqG0hehYr25C/XTHXJ+c5B5reaWKwuYW1Smpg7 whVLUcEHVFiU32bMFiETKfNVIGa3mxNUfO9wHpqBD4lSUNr3eJao5R25t5NMDJkL /znRsFb5h49uZEASjBWTICIsKjfjqaydRS5oQ9VZZcxdo3azZboqxLeuEAUnSSrn H8/F6HNbSJ5MVetRG2DrLpWFCS94LSjhF4DYQk0xzK3lvMXHMrdhZI0G94ZTx9PW X2I5+Y9cj1mVLzWrxHyu =W4Zd -----END PGP SIGNATURE-----
