On 2/20/15 12:10 PM, Ben de Groot wrote:
> At the suggestion of radhermit, I'm putting my neovim & deps ebuilds
> up here for review, before I commit them to the official tree. Do you
> see any possible improvements?

Overall the ebuilds look nice and clean. Some ideas:

- consider asking libtermkey upstream to provide a way to make demos
optional in a cleaner way than sed over the Makefile

- in neovim-python-client, 0.0.28.tar.gz is hardcoded in the ebuild;
consider using ${PV} instead

Paweł

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to