On Sun, Dec 7, 2014 at 5:05 AM, Anthony G. Basile <bas...@opensource.dyc.edu> wrote: > 0) This reduces code reusability. The eclass is used by sys-devel/kgcc64 in > the tree and (at least) the hardened-dev::musl overlay outside.
Yes, but while your claim that it reduces reusability is true, I think that's potentially a good thing. With all of the logic encoded in that huge eclass, any modifications to it change the code any version of the gcc ebuild executes, including stable versions that you're not thinking about at the time. eclasses are pretty great for sharing code akin to a library, but when *all* of your ebuild's logic is in the eclass, well, that's not really the intended use case as far as I can tell. glibc does the same thing with "eblits." I think I remember Ciaran making the same argument in the past, but much better said than mine.
