On Thu 27 Mar 2014 07:51:32 Michał Górny wrote: > Dnia 2014-03-27, o godz. 02:13:52 Mike Frysinger napisał(a): > > On Wed 26 Mar 2014 01:17:14 Mike Frysinger wrote: > > > (2) use tuples with loaded vendor fields to reduce the chance of > > > collisions. e.g. having an ABI=amd64 system use > > > i686-gentoo%multilib-linux-gnu instead of i686-pc-linux-gnu would > > > defeat any automatic path searches. > > > > this patch keeps the status quo. although the status quo is broken, but > > we > > can sort that out independently. > > Except that it breaks stuff that is installed at the point and comes > with no plan of cleaning up the resulting mess.
such as ... ? vague statements can't be addressed.
> > --- profiles/arch/amd64/make.defaults 18 Jan 2014 01:03:24 -0000
> > 1.21
> > +++ profiles/arch/amd64/make.defaults 27 Mar 2014 06:13:22 -0000
> > @@ -21,17 +21,17 @@ ABI="amd64"
> >
> > # 64bit specific settings.
> > CFLAGS_amd64="-m64"
> > LDFLAGS_amd64="-m elf_x86_64"
> >
> > -CHOST_amd64="x86_64-pc-linux-gnu"
> > +CHOST_amd64="${CHOST}"
> >
> > # 32bit specific settings.
> > CFLAGS_x86="-m32"
> > LDFLAGS_x86="-m elf_i386"
> >
> > -CHOST_x86="i686-pc-linux-gnu"
> > +CHOST_x86="i686-gentoo%multilib-linux-gnu"
>
> Using percent sign here looks like asking for trouble at some point.
> I don't see why you can't use plain 'gentoomultilib' that is more
> fool-proof.
i merely picked a value that was highly unlikely for people to use. the %
should be safe as it is not interpreted by the shell and strongly indicates
"hey man, don't mess with me". it could just as easily be a _ or nothing at
all. i don't feel strongly about it.
-mike
signature.asc
Description: This is a digitally signed message part.
