On Wed, Dec 11, 2013 at 2:40 PM, Michał Górny <mgo...@gentoo.org> wrote:
>> This patch adds multilib_src_{configure,compile,test}_all
>> callbacks, analogous to the existing multilib_src_install_all
>> callback.
>
> No real benefit in having those.There is no fundamental semantic benefit I can think of; indeed, as pointed out above, the "portage-standard" phase-function-implementation-override + direct-invocation-of-overridden-phase-function recipe has slightly greater semantic power. However, subjectively speaking, I feel that using the multilib_<phase>_all callbacks make for cleaner and easier to follow code. My thinking was that providing two ways to achieve the same thing should be harmless -- ebuild authors are, after all, coding bash scripts to run in a UNIX-like environment, so hopefully they are comfortable choosing between multiple-ways-to-do-it :) However, I'm not so attached to this patch that I'd put up a big fight over it; my overlay doesn't use them, and they are, strictly-speaking, superfluous. -gmt
