-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/18/2013 12:39 PM, Ulrich Mueller wrote: > Hi all, > > For EAPI 6, introduction of a patch applying function to the package > manager itself is being discussed. This would serve two purposes: > - support for PATCHES variable in a default src_install phase > - a function to apply user patches
Isn't src_install a bit late for most patches? > > In bug 463768 the conclusion so far was that implementing the full > epatch function in the package manager is not feasible. Therefore, > the package manager's implemention would have reduced functionality. > The current epatch() would remain available in eutils.eclass for cases > where its more advanced modes of operation are needed. > > The feature list we came up with (see bug 463768 comment 32) includes > support for regular patch files, of course. It also includes support > for directories, with patches applied in lexical order of their > filenames (only files named *.diff and *.patch). > > So, the questions that I'd like to ask are: > 1. Is the above set of features reasonable? > 2. Should the function do automatic -p* detection, or should it > default to -p1? Both would be overridable by an explicit -p* > option. There are good arguments for either variant (see the > above-mentioned bug). Pretty please autodetection. It's a very nice feature that we seem to already have sanely implemented. Thanks, Zero > 3. So far, we don't have a good name for the function. > > Ulrich > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSEQM5AAoJEKXdFCfdEflKGqUP/iBvycWstFl33uNSLLgYTFbt joA3Q6hmEjQmOJSqmSSazJzvKzvlVF2PlShKq2SzHcTr7WPXCXVcZuC1DbKZEnA1 ZHPgYrxb+KN7/V+Eh7i4CEslhnf9DPqBsHZc5dh/tX3jHeVPcSphDrz96TVnEtT/ FIY0RPIYCfDOPjQHQaeCorNoZNTU54box2iCj0UwwWRLQeMDyuS9LAT0BNUBBi4M 9q6dCAZe+Z1hUgDE93VxeT4a7h4ytlYlfi8COQxZubqhOczXLL7p5UobUy6QuqLY TiUAvd+c69iU7zvhERKiEJcxapDhfxFqqYL1m+Zs+0ZAVEaMQkeHnWFY+Rdz8an5 iOnqW6r8LYit2upqyUS582gyTkw1+3aYBOITtSxHvZq4JSSCNuc7rp8HXMjYMaUh TN10qb4/PtbRkJDnALH/3+F3Dzu55ujSJgn0QH4+5+Ect82NjlSPD1jBRsHkATq+ 04kHeGuvj2yp6UuT9Qt5ndbDEzy7eSVCrIeXx4J7YgCj6xU1cAl3X7QjCD+yx/K6 xNd6swsvjiBPdDSzSiBxDDTdvFj9585Zw4iT+uIm7MMXKM7thNEJK6yuVLkOU1Gh kahndJdAQkE5t09tMr5c0wdvD0fXGXQNk2nMaykLbXwAF3zJRccP1enytufdxgQR WyaQpr7+jTp851spxxgm =NTh+ -----END PGP SIGNATURE-----
