On 08/09/2013 11:10 AM, Michał Górny wrote: > Dnia 2013-08-09, o godz. 09:47:38 > Zac Medico <zmed...@gentoo.org> napisał(a): > >> On 08/09/2013 02:32 AM, Michał Górny wrote: >>> Hello, >>> >>> Just a quick one. >>> >>> Currently, the two listed variables are set in make.globals (installed >>> by portage ebuild); >>> >>> COLLISION_IGNORE="/lib/modules/* *.py[co] *\$py.class" >>> UNINSTALL_IGNORE="/lib/modules/*" >>> >>> COLLISION_IGNORE specifies files that will be ignored by >>> FEATURES=collision-protect when they exist but are not owned by any >>> package. UNINSTALL_IGNORE specifies files that will not be unmerged. >>> >>> By keeping those two in portage, we're basically binding them to >>> version of portage installed. If we need to ignore more files, we need >>> to request our users to upgrade portage. >>> >>> That's why I'm thinking of moving them to profiles/base/make.defaults. >>> From what I've tested, the setting there will override make.globals >>> and therefore the change could be effective from day one, without >>> the need to upgrade portage. >>> >>> I feel like those variables are much alike the QA variables that we >>> keep in the profiles. >>> >>> What do you think? >> >> I guess it's fine. I would do it like this in order to respect the >> portage default setting: >> >> COLLISION_IGNORE="${COLLISION_IGNORE} new stuff" > > Well, the intent was to put the current default in there, and drop it > in next version of portage since it is specific to gx86 eclasses > and ebuilds.
Well, the /lib/modules/* setting specifically complements portage's UNINSTALL_IGNORE setting, so that would be one reason to inherit the portage setting, in case portage changes its default config somehow. -- Thanks, Zac