On Sat, 2 Feb 2013 23:33:26 +0000
"Aaron W. Swenson" <titanof...@gentoo.org> wrote:

> After years of "if use test ; then ..." just working when
> FEATURES="test" is declared, it isn't working with EAPI5. I think we
> could save some bytes and headaches if we just add "test" to
> IUSE_IMPLICIT.
> 
> Portage's emerge's "--newuse" option won't be affected by this. From
> `man emerge`:
> > NOTE: This option ignores the state of the "test" USE flag, since
> > that flag has a special binding to FEATURES="test" (see make.conf(5)
> > for more information about FEATURES settings).
> 
> What say you?
> 

That test shouldn't be a useflag in the first place, that there should
be a TESTDEPEND and a dedicatated function defined in PMS to let the
ebuild check if src_test will be executed. 'test' as we use it is
pretty much a hack.

Another note, 'if use test; then' is often very similar in nature to
conditional patching and should be avoided where reasonably possible.


Either way, I'm against adding test to IMPLICIT_IUSE on the basis of 'I
was lazy and want to continue to do so'.

Regards
Ralph

Attachment: signature.asc
Description: PGP signature

Reply via email to