On 3/31/12 8:45 AM, Fabian Groffen wrote:
> On 30-03-2012 13:00:33 +0200, "Paweł Hajdan, Jr." wrote:
>> This is from gnustep-base.eclass:
>>
>>> egnustep_doc() {
>>> if [[ -d ./Documentation ]] ; then
>>> # Check documentation presence
>>> cd "${S}"/Documentation
>>> if [[ -f ./[mM]akefile || -f ./GNUmakefile ]] ; then
>>> emake "${GS_ENV[@]}" all || die "doc make failed"
>>> emake "${GS_ENV[@]}" install || die "doc install failed"
>>> fi
>>> cd ..
>>> fi
>>> }
>>
>> Shouldn't those cd calls above rather be pushd/popd? It seems the above
>> assumes that CWD is "${S}" when egnustep_doc is executed, which is
>> probably true, but pushd/popd seems just safer.
>
> Go ahead.I've checked in this and all other changes to CVS, after testing gnustep packages locally. Paweł
signature.asc
Description: OpenPGP digital signature
