On Fri, 23 Mar 2012 11:58:47 -0400
Mike Gilbert <flop...@gentoo.org> wrote:

> On Fri, Mar 23, 2012 at 4:15 AM, Alexis Ballier <aball...@gentoo.org>
> wrote:
> 
> > DEPEND=">=dev-lang/ocaml-3.12[ocamlopt?]"
> > DEPEND="${RDEPEND}"
> 
> That looks like a typo.

yes, thanks for spotting

> 
> > oasis_src_compile() {
> >     oasis_src_compile_no_doc
> >     if has doc ${IUSE} && use doc; then
> >             ocaml setup.ml -doc || die
> >     fi
> > }
> 
> This should probably call use_if_iuse from eutils.eclass, which
> handles IUSE="[+-]doc".
> 

hmm, actually, I like the idea of something like OASIS_WANT_DOCS as
suggested by Ciaran, this sounds simpler and, as a side effect, will
allow me to kill the useless oasis_src_compile_no_doc function.

I'll come back with something like this and post an update, most likely
next week, pilling up the reviews :=)


A.

Reply via email to