On Tue, 11 Oct 2011 14:50:30 -0400 Matt Turner <matts...@gentoo.org> wrote:
> On Tue, Oct 11, 2011 at 2:34 PM, Samuli Suominen
> <ssuomi...@gentoo.org> wrote:
> > I just hope nobody will take an example of the ebuild with code
> > duplication (multiple epatch calls), overquoting, redudant use of
> > find when rm is more than enough, ...
>
> I haven't looked, but if we don't already, a little style guide would
> be very cool. I wouldn't think of most of these things without seeing
> it somewhere else first.
>
> It looks like the epatch devmanual page uses multiple calls. :\
I don't think that passing multiple files to epatch actually improves
readability. Simple example:
# bug #123456, foo, bar
epatch "${FILESDIR}"/${P}-foo.patch
# bug #234567, baz bazinga blah blah
epatch "${FILESDIR}"/${P}-baz.patch
With multiple arguments, you can't put comments in the middle.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
