"Paweł Hajdan, Jr." <phajdan...@gentoo.org> said: > On 2/21/10 5:08 AM, Ryan Hill wrote: > > I have one simple request. When you make a non-trivial change to an > > ebuild - a patch, a version bump, anything that can effect the > > behaviour of the package - please run the test suite. > > Yeah, on my dev box I just run with FEATURES="test" all the time. Then > it's impossible to forget it. And I also catch failures in other > packages. > > Maybe it should get more exposure in the developer docs? > > > If it fails, fix it. Or restrict it. Or even make it non-fatal if > > there's no other choice. > > It's really frustrating when there is a bug reported about package > failing tests and everybody can reproduce it, yet the maintainer > doesn't at least put RESTRICT="test" in the ebuild. > > Is it acceptable for another dev to jump in and add RESTRICT="test" to > an ebuild if the maintainer does not respond to a bug report in a > timely manner?
IMHO yes! of course, the bug has to be left open until the issue is fixed for real. > > The concern here may be that it's papering over the real problem, but > the good side is that it'd make running with FEATURES=test much easier. which is a good thing, since more tests will be run. RESTRICT="test" should always generate a repoman QA warning IMHO. > > By the way, for packages that fail the test suite and refuse to disable > it, I change the env locally so that FEATURES=-test (via > /etc/portage/env). how many packages do you have in there? i usually just do it manually, so i dont have easily available stats on how many packages are affected. > > Paweł Hajdan jr
signature.asc
Description: This is a digitally signed message part.
