-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dne 1.2.2010 14:14, Peter Volkov napsal(a):
> В Пнд, 01/02/2010 в 11:35 +0100, Tomáš Chvátal пишет:
>> As I was reworking the x-modular-r2 eclass I found out that most of the
>> slowdowns for fonts were produced in fonts eclass.
>
> Exactly what slowdowns are you talking about? I've reviewed all changes
> and I don't see any noticeable performance improvements anywhere. Or
> what do you mean?
Well it might be visible if you use some font from overlay and from main
tree (overlay use also the x-modular-r2) not sure which changes helped
it more :P
>
>> I would like to ask you to review the changes and spot anything that
>> might slipped my sight.
>
> 1.
> -FONT_SUFFIX=${FONT_SUFFIX:-}
> +: ${FONT_SUFFIX:=}
>
> What are the benefits of this change? Personally I prefer first syntax
> more since it's more evident and does not need to run empty command :
I am just used to this syntax. I dont think it is so huge issue that it
would need revert.
>
> 2.
> if has X ${IUSE//+} && use X ; then
>
> I'm not sure. With this change should we update all packages depending
> on font.eclass to have X in IUSE?
Nak this specialy allows that you dont have to keep X in iuse.
But it does not matter anyway because it is and was always defined by
eclass. But with this syntax it allows us to remove that IUSE="X" from
eclass global scope at some point.
>
> 3.
> If you dropped
>
> if has_version '>=media-libs/fontconfig-2.4'; then
>
> then >=media-libs/fontconfig-2.4 should be in DEPEND.
Probably yes, but think when was the 2.3 removed from portage :] (Jul 2007).
Dep added.
>
> 4.
> + [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation
> failed" ; }
>
> This should be non fatal, until somebody installs all packages that
> inherit font.eclass and assures us that nothing broke with this change.
>
Actualy former behaviour was violating QA rules for dodoc, so it should
be fixed anyway.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAktm1y8ACgkQHB6c3gNBRYe7GACfclA2J/2eMSw/wZJnfT9E2/4G
uB0AnRhnJ9RoiaoMwTkPASFMSlEx4XkY
=f/72
-----END PGP SIGNATURE-----
