On 17:55 Wed 12 Mar , Justin Bronder (jsbronder) wrote:
> 1.1 sys-cluster/torque/torque-2.3.0.ebuild
>
> file :
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/torque/torque-2.3.0.ebuild?rev=1.1&view=markup
> plain:
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/torque/torque-2.3.0.ebuild?rev=1.1&content-type=text/plain
> pkg_setup() {
> linux-info_pkg_setup
> if use cpusets && ! use kernel_linux; then
> einfo
> elog " Torque currently only has support for cpusets in
> linux."
> elog "Assuming you didn't really want this USE flag."
> einfo
> elif use cpusets; then
> einfo
> elog " Torque support for cpusets is still in development,
> you may"
> elog "wish to disable it for production use."
> einfo
> if ! linux_chkconfig_present CPUSETS; then
> einfo
> elog " Torque support for cpusets will require that
> you recompile"
> elog "your kernel with CONFIG_CPUSETS enabled."
> einfo
> fi
> fi
This logic is really strange. Try this instead:
if use cpusets; then
if ! use kernel_linux; then
...
else
...
fi
fi
> }
>
> src_compile() {
> local myconf="--with-rcp=mom_rcp"
>
> use crypt && myconf="--with-rcp=scp"
>
> if use cpusets && use kernel_linux; then
> myconf="${myconf} --enable-cpusets"
> fi
The same logic is duplicated, once here and once earlier. It might be
nicer to just do it once, perhaps by setting a variable and checking it.
Thanks,
Donnie
--
gentoo-dev@lists.gentoo.org mailing list
