On 13-02-2008 08:50:19 +0100, Rémi Cardona wrote: > Petteri Räty a écrit : >> What do you think about adding support to base.eclass for running >> eautoreconf?
> In most of the ebuilds where we need to run eautoreconf, we usually apply > patches. I can't remember of an ebuild where we just run eautoreconf on its > own. +1 If you need to run eautoreconf without adding patches, it may be worth adding a comment explaining why. > In the end, that won't help us at all (which is no reason not to have this > :) ) but I'm afraid that adding options for semi-hidden stuff can come and > bite us later, as we add more and more of those. I think it should not be added as it hides something quite important. - it takes a lot of time on most platforms I run - it may break (especially during bootstrapping, eautoreconfs are hell) - it may introduce extra deps/caution (e.g. gettext macros being available) So I'd prefer to keep it quite clear that this is happening, instead of hiding it somewhere in an obscure corner of the ebuild. -- Fabian Groffen Gentoo on a different level -- gentoo-dev@lists.gentoo.org mailing list
