Donnie Berkholz <[EMAIL PROTECTED]> wrote:
> On 15:05 Mon 17 Dec     , Jim Ramsay (lack) wrote:
> > lack        07/12/17 15:05:57
> > IUSE="+svg +video"
> 
> svg already defaults on for all the desktop profiles, so I'm not
> really sure what that's gaining you.

Good point, removed '+' there

> > RDEPEND=">=x11-libs/gtk+-2.4
> >     >=dev-libs/glib-2.2
> >     >=dev-libs/libxml2-2.4.23
> >     >=x11-misc/shared-mime-info-0.14
> >     svg? ( gnome-base/librsvg )
> >     !ppc? ( rox-base/mime-editor
> >             rox-base/thumbs
> >             video? ( rox-extra/videothumbnail ) )"
> 
> PPC users aren't supposed to get this stuff? If not, is it even a
> real dependency?

I'm waiting on bug 201983 for ppc to keyword those ebuilds.  They are
semi-optional runtime dependencies.  I'll explain further:

There are buttons in the ROX application's "options" window which
launch each of these applications.  Thus they are not *strictly*
required for basic operation, but are required for all the buttons in
the app to actually work.  videothumbnail is USE-dependent because it
needs either mplayer or totem, neither of which are very quick to
install.  The other two however (mime-editor and thumbs) are reasonably
simple python apps that really only take a second or so to download and
install.

> >             (cd src; make clean) > /dev/null
> 
> Subshells are icky.

I agree, replaced them all with pushd/popd instead.

> >     chmod 0755 "${D}/usr/bin/${WRAPPERNAME}"
> >     chmod 0755 "${D}/usr/bin/${WRAPPERNAME}uri"
> 
> fperms?

Ah yes.  Done.
 
> >     make_desktop_entry ${WRAPPERNAME} ${APPNAME} ${APPNAME}.png
> > "System;Utility;Core;ROX"
> 
> Thought I saw something about desktop entries dropping the suffix for 
> the icon, but I don't recall the details.

Yes, this is correct.  I have removed it.  Also technically speaking
there is no 'ROX' category (any more?) so I have removed it as well and
made it better match the defined menu categories.

-- 
Jim Ramsay
Gentoo/Linux Developer (rox,gkrellm)

Attachment: signature.asc
Description: PGP signature

Reply via email to