On Tuesday 25 September 2007, Peter Volkov wrote: > В Пнд, 24/09/2007 в 12:56 -0700, Donnie Berkholz пишет: > > > if use ppc ; then > > > sed -i -e 's:-Werror::g' src/Makefile > > > fi > > > > We should never leave -Werror in -- make this unconditional. > > "never" is too strong: for example, wireshark's upstream told me that > they want code to be built with -Werror. If something breaks they are > interested in report to fix that.
not really ... what builds today on $arch with $gcc_version is no guarantee it'll work on any other $arch or $gcc_version (and considering the change of warnings in gcc, this makes it likely) -Werror makes sense in development code, but not releases (ever) ... forcing -Werror just makes for annoyed users and that flag really should be an "opt-in" thing (aka, put it in your CFLAGS) this is exactly why the werror stuff in binutils has been disabled for pretty much ever then again, while i think it's pretty stupid, i'm not about to go around and force people to remove it ... -mike
signature.asc
Description: This is a digitally signed message part.
